[web] allow imports to line-break #57170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
reviewed
Dec 12, 2024
web_sdk/sdk_rewriter.dart
Outdated
| @@ -79,6 +79,7 @@ List<Replacer> generatePartsPatterns(String libraryName, bool isPublic) { | |||
| // Remove library directives. | |||
| AllReplacer(RegExp(r'\nlibrary .+;'), ''), | |||
| // Remove imports/exports from all part files. | |||
| AllReplacer(RegExp(r"\nimport '.+'\n\s*if \(dart.library.html\) '.*';"), ''), | |||
There was a problem hiding this comment.
can we not hardcode dart.library.html or maybe also allow for dart.library.js_interop as well, so our code doesn't mysteriously break when we migrate the code to not referencing dart.library.html? Bugs in the sdk rewriter are very hard to pinpoint :/
yjbanov
changed the title
yjbanov
force-pushed
the
allow-imports-to-line-break
branch
from
045cd24 to
81816cc
Compare
|
Looks like something is still failing with the line breaks… |
mdebbar
approved these changes
Dec 13, 2024
|
@yjbanov I think we need to remove this restriction now: engine/web_sdk/test/js_access_test.dart Lines 184 to 187 in f0ff4f2 (this is what's causing the CI failure) |
|
Yep, fixed. |
yjbanov
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are about to
dart formatall the Dart code in the repo, which line-breaks some of our imports.This PR updates
sdk_rewriter.dartto support line-broken imports.