Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental] retire directory #2520

Open
ericwindmill opened this issue Dec 2, 2024 · 13 comments
Open

[experimental] retire directory #2520

ericwindmill opened this issue Dec 2, 2024 · 13 comments
Labels
p1 retire Sample should be retired according to contributing guidelinces.

Comments

@ericwindmill
Copy link
Contributor

Experimental samples are not appropriate for this repository, because Flutter developers can't use them as a guide today, which is one of the requirements for this repository. See contributing guide for more information.

@ericwindmill ericwindmill added the p1 label Dec 2, 2024
@ericwindmill ericwindmill changed the title [experimental] Retire directory [experimental] retire directory Dec 2, 2024
@ericwindmill ericwindmill added the retire Sample should be retired according to contributing guidelinces. label Dec 2, 2024
@domesticmouse
Copy link
Contributor

Part of the reason for this directory was the needs of the Material team to have a place for code at master/main because that is where they live. Retirement of this directory would cut off that source of maintenance. I'd suggest that you should discuss this with the owners of the various experimental samples before shuttering this.

@ericwindmill
Copy link
Contributor Author

Part of the reason for this directory was the needs of the Material team to have a place for code at master/main because that is where they live. Retirement of this directory would cut off that source of maintenance. I'd suggest that you should discuss this with the owners of the various experimental samples before shuttering this.

I plan on talking to all stakeholders before I act on any of the 'retire' issues I created yesterday. I've created the tickets so there's a natural place to have the conversations about individual samples. I fully expect that some of them will be just closed without updates

@zanderso
Copy link
Member

zanderso commented Dec 3, 2024

FYI @jonahwilliams the text/font puzzle game demo lives here https://github.com/flutter/samples/tree/main/experimental/varfont_shader_puzzle.

@jonahwilliams
Copy link
Member

We're not currently using this sample for anything.

@ericwindmill
Copy link
Contributor Author

FYI - These samples can be moved if they're valuable for a reason I don't see and they run on the stable channel today.

@Piinks
Copy link
Contributor

Piinks commented Dec 4, 2024

The date_planner app was checked in to experimental to run against master while we work on iOS improvements, I think the iOS team was also planning to use it for benchmarking. cc @jmagman

We were about to check in rolodex as well in experimental to run against master as we finish polishing Cupertino. cc @MitchellGoodwin

@jmagman
Copy link
Member

jmagman commented Dec 4, 2024

The date_planner app was checked in to experimental to run against master while we work on iOS improvements, I think the iOS team was also planning to use it for benchmarking. cc @jmagman

The iOS team isn't planning on using this app for benchmarking, afaik. Right @LouiseHsu?

@LouiseHsu
Copy link

Yep I wasnt planning on using it.

@ericwindmill
Copy link
Contributor Author

ericwindmill commented Dec 4, 2024

Good call, @Piinks, I didn't consider where I'd move date_planner.

I need to consider the best way to handle large demo apps that are in active development, but my gut says that I'm just going to move it out experimental and add whichever qualifiers I need to add to the readme, like that it's incomplete or is tested against master.

FWIW The problem I'm trying to solve by deleting experimental is that it's often a dumping ground where things are checked in and then forgotten. I'm discouraging any samples that can't pass CI against stable as a rule, but all rules have exceptions. 

@Piinks
Copy link
Contributor

Piinks commented Dec 4, 2024

The problem I'm trying to solve by deleting experimental is that it's often a dumping ground where things are checked in and then forgotten.

You have my full support. 💯

If we need to find another home for rolodex and date_planner, can do!

@HosseinYousefi
Copy link
Member

The pedometer example works on the stable channel even though it's on experimental. It's also maintained by me.

@domesticmouse
Copy link
Contributor

The pedometer example works on the stable channel even though it's on experimental. It's also maintained by me.

Can we move the pedometer out of experimental into the main directory?

@HosseinYousefi
Copy link
Member

Can we move the pedometer out of experimental into the main directory?

SGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 retire Sample should be retired according to contributing guidelinces.
Projects
None yet
Development

No branches or pull requests

8 participants