-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experimental] retire directory #2520
Comments
Part of the reason for this directory was the needs of the Material team to have a place for code at |
I plan on talking to all stakeholders before I act on any of the 'retire' issues I created yesterday. I've created the tickets so there's a natural place to have the conversations about individual samples. I fully expect that some of them will be just closed without updates |
FYI @jonahwilliams the text/font puzzle game demo lives here https://github.com/flutter/samples/tree/main/experimental/varfont_shader_puzzle. |
We're not currently using this sample for anything. |
FYI - These samples can be moved if they're valuable for a reason I don't see and they run on the stable channel today. |
The date_planner app was checked in to experimental to run against master while we work on iOS improvements, I think the iOS team was also planning to use it for benchmarking. cc @jmagman We were about to check in rolodex as well in experimental to run against master as we finish polishing Cupertino. cc @MitchellGoodwin |
The iOS team isn't planning on using this app for benchmarking, afaik. Right @LouiseHsu? |
Yep I wasnt planning on using it. |
Good call, @Piinks, I didn't consider where I'd move date_planner. I need to consider the best way to handle large demo apps that are in active development, but my gut says that I'm just going to move it out experimental and add whichever qualifiers I need to add to the readme, like that it's incomplete or is tested against master. FWIW The problem I'm trying to solve by deleting experimental is that it's often a dumping ground where things are checked in and then forgotten. I'm discouraging any samples that can't pass CI against stable as a rule, but all rules have exceptions. |
You have my full support. 💯 If we need to find another home for rolodex and date_planner, can do! |
The pedometer example works on the stable channel even though it's on experimental. It's also maintained by me. |
Can we move the pedometer out of experimental into the main directory? |
SGTM! |
Experimental samples are not appropriate for this repository, because Flutter developers can't use them as a guide today, which is one of the requirements for this repository. See contributing guide for more information.
The text was updated successfully, but these errors were encountered: