From 528aec32dc96459846d3095423a25aa758053370 Mon Sep 17 00:00:00 2001 From: Greg Price Date: Mon, 20 May 2024 15:58:01 -0700 Subject: [PATCH 1/3] Add zulip.test Zulip is an open-source team chat app, with a new Flutter-based mobile client now in beta. This is that client's test suite. I believe these will be the only tests currently in this registry for an app, rather than a library. That should naturally give them a different mix of use cases and types of tests. Concretely, we've seen a handful of breaking changes over the past year that weren't caught by any of Flutter's existing test suites. These were in text hit-testing: https://github.com/zulip/zulip-flutter/commit/ba7a2bfe50aa99d79a03535ade4eab252d07c9e7 https://github.com/flutter/flutter/pull/140621 and Material menu behavior: https://github.com/zulip/zulip-flutter/commit/38ed6c812defcb5da8c2d9185e95fc2eaf1eb37b https://github.com/flutter/flutter/pull/130536 and SlottedContainerRenderObjectMixin gaining a type parameter: https://github.com/zulip/zulip-flutter/commit/2f0f4692f2d55748d055ac7c140ab7414307a36d https://github.com/flutter/flutter/pull/126108 I'm not complaining, to be clear, and none of these were particularly onerous for us to adapt to. By registering these tests, I'm hoping to provide feedback on future such breakages at a point where it's actionable. Omitted here are several tests that re-generate generated files and check they match what's in the tree. Those are pretty slow, and I think they're pretty insensitive to changes in the Flutter tree anyway; rather they depend on pigeon, json_serializable, build_runner, and drift_dev. --- registry/zulip.test | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 registry/zulip.test diff --git a/registry/zulip.test b/registry/zulip.test new file mode 100644 index 00000000..0172f59c --- /dev/null +++ b/registry/zulip.test @@ -0,0 +1,11 @@ +contact=greg@zulip.com +contact=cbobbe@zulip.com + +fetch=git clone https://github.com/zulip/zulip-flutter.git tests +fetch=git -C tests checkout 316cc1a7cc723bc01235cfa31f6cc5ae2836fda6 + +update=. +update=packages/zulip_plugin + +test=flutter analyze --no-fatal-infos +test=flutter test From 3a0d9e2fc9208cf04770dc3a8bcabc2369c300f9 Mon Sep 17 00:00:00 2001 From: Greg Price Date: Wed, 22 May 2024 15:22:15 -0700 Subject: [PATCH 2/3] Bump zulip to skip a test on Windows --- registry/zulip.test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/registry/zulip.test b/registry/zulip.test index 0172f59c..2a5aa648 100644 --- a/registry/zulip.test +++ b/registry/zulip.test @@ -2,7 +2,7 @@ contact=greg@zulip.com contact=cbobbe@zulip.com fetch=git clone https://github.com/zulip/zulip-flutter.git tests -fetch=git -C tests checkout 316cc1a7cc723bc01235cfa31f6cc5ae2836fda6 +fetch=git -C tests checkout 9ea05846858fe36a9820f01917eebce466cb8456 update=. update=packages/zulip_plugin From 63f72c0310870e96764723c66a9096f0c9b6f036 Mon Sep 17 00:00:00 2001 From: Greg Price Date: Wed, 22 May 2024 19:59:04 -0700 Subject: [PATCH 3/3] Skip zulip on Windows --- registry/zulip.test | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/registry/zulip.test b/registry/zulip.test index 2a5aa648..3586b2fc 100644 --- a/registry/zulip.test +++ b/registry/zulip.test @@ -7,5 +7,5 @@ fetch=git -C tests checkout 9ea05846858fe36a9820f01917eebce466cb8456 update=. update=packages/zulip_plugin -test=flutter analyze --no-fatal-infos -test=flutter test +test.posix=flutter analyze --no-fatal-infos +test.posix=flutter test