Remove flutter_svg tests #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work towards https://github.com/dart-lang/linter/issues/5063 This repo refers to the `avoid_null_checks_in_equality_operators` lint rule, which is being removed as per https://github.com/dart-lang/linter/issues/5063. This repo is also being migrated, as I understand it. I suggest we disable for now, and can remove the `avoid_null_checks_in_equality_operators` enablement after the migration, and re-enable the tests then.
|
We won't re-enable the tests, because the repo itself will be in flutter/packages its already in our CI. Instead I would recommend completely removing the flutter_svg entry from here |
|
Ah yes, OK updated the title, description, and code. Thanks! |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards dart-lang/sdk#59514
This repo refers to the
avoid_null_checks_in_equality_operatorslint rule, which is being removed as per dart-lang/sdk#59514.This repo is also being migrated, as I understand it. Let's remove it from the customer tests registry.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.