Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable dartrfb #427

Merged
merged 1 commit into from
Nov 19, 2024
Merged

re-enable dartrfb #427

merged 1 commit into from
Nov 19, 2024

Conversation

Goddchen
Copy link
Contributor

@Goddchen Goddchen commented Nov 13, 2024

since the deprecated lint rules have been removed

See these 2 PRs: Goddchen/dart-rfb#26 and Goddchen/dart-rfb#25

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Copy link

auto-submit bot commented Nov 17, 2024

auto label is removed for flutter/tests/427, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@parlough parlough requested a review from srawlins November 19, 2024 03:39
Copy link
Contributor

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@auto-submit auto-submit bot merged commit 6b2853b into flutter:main Nov 19, 2024
12 checks passed
@auto-submit auto-submit bot removed the autosubmit label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants