Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Re-enable DevTools tests" #433

Closed
wants to merge 1 commit into from

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Dec 13, 2024

Reverts #432 to unblock flutter/flutter#160174

@bkonyi bkonyi requested a review from kenzieschmoll December 13, 2024 15:53
@kenzieschmoll
Copy link
Member

Why are we reverting this? There are more changes in the PR that is being reverted than just re-enabling the test. If we need to disable the test temporarily to fix a legitimate failure, we can just rename the test registry file to end in .disabled without reverting the other changes in #432.

@bkonyi bkonyi closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants