Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contextual-survey-metadata.json for pilot test #1 #113

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

jayoung-lee
Copy link
Contributor

The URL for "More Info" may be update later to /user-surveys once flutter/website#8654 is merged

The URL for "More Info" may be update later to `/user-surveys` once flutter/website#8654 is merged
@eliasyishak
Copy link
Contributor

I think you may also want to make the conditions array empty since you want to test with everyone right? As it stands right now, each user testing this feature would need to have already sent 1000 events previously, which may not be the case for everyone.

https://github.com/flutter/uxr/pull/113/files#diff-bdf7173921cada97180d013ce22fd3e8c7560bb877eddbb417724eeb29a3ed8cR13-R19

@eliasyishak
Copy link
Contributor

eliasyishak commented Oct 13, 2023

Also if you want to test the snooze functionality, we may want to try a snooze period less than 7200 minutes? Perhaps something like 2-5 minutes to test the snooze functionality?

https://github.com/flutter/uxr/pull/113/files#diff-bdf7173921cada97180d013ce22fd3e8c7560bb877eddbb417724eeb29a3ed8cR8

- Snooze for 1 day
- Empty the conditions
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, LGTM.. you changed the snooze minutes to 24 hours now it seems so you'll be testing this over the span of 2 days?

@jayoung-lee
Copy link
Contributor Author

Hi Elias, thanks for reviewing! 5 minutes makes more sense, actually. Updated!

@jayoung-lee jayoung-lee merged commit 2241dc4 into master Oct 13, 2023
5 checks passed
@jayoung-lee jayoung-lee deleted the jayoung-lee-patch-1 branch October 13, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants