-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorter ignores // ignore: implementation_imports above imports when sorting #38
Comments
👋 Hello! Thanks for submitting a issue! @Matt-Gleich will try to respond as soon as possible. |
Hello @SchnMar! Mind sending an example file so it easier for me to debug? Thanks! |
Hallo @Matt-Gleich, thank you for your help and sorry for the late reply. I have the following imports prior to sorting:
After sorting, the imports appear like this:
This leads to me annotating with ```//ignore: implementation_imports after every sort. What do you think? I'm aware that I shouldn't be doing this, but in this case I think it's reasonable to do so. |
I also encounter this issue. My Dart file: import 'package:flutter/widgets.dart';
import 'package:easy_localization/easy_localization.dart';
// ignore: implementation_imports
import 'package:easy_localization/src/localization.dart';
import 'package:logging/logging.dart';
import 'l10n.dart';
import 'package:flutter/widgets.dart';
import 'package:easy_localization/easy_localization.dart';
import 'package:easy_localization/src/localization.dart';
import 'package:logging/logging.dart';
import 'l10n.dart';
// ignore: implementation_imports
A workaround I found is to put |
See #63 |
Describe the bug
I use // ignore: implementation_imports in my project above some imports because I use some packages and their implementation.
To Reproduce
What command or actions did you take to produce this error?
I added these comments and ran
flutter pub run import_sorter:main
. Now these comments are listed below all the imports and not above the imports, which actually import implementation from packages.Expected behavior
I expected that the comments are sorted with the imports.
Please let me know, if you need additional information. Thank you for your help.
The text was updated successfully, but these errors were encountered: