Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: connectivity_plus Android Broadcast sends String instead of List #2671

Closed
8 tasks done
miquelbeltran opened this issue Mar 11, 2024 · 1 comment · Fixed by #2673
Closed
8 tasks done

[Bug]: connectivity_plus Android Broadcast sends String instead of List #2671

miquelbeltran opened this issue Mar 11, 2024 · 1 comment · Fixed by #2673
Assignees
Labels
android bug Something isn't working connectivity_plus Connectivity Plus

Comments

@miquelbeltran
Copy link
Member

Platform

Android

Plugin

connectivity_plus

Version

main

Flutter SDK

all

Steps to reproduce

See PR #2668

Code in this line seems to be wrong, it should call the broadcast success method with an array, not with a String.

https://github.com/fluttercommunity/plus_plugins/blob/main/packages/connectivity_plus/connectivity_plus/android/src/main/java/dev/fluttercommunity/plus/connectivity/ConnectivityBroadcastReceiver.java#L91

fyi @suquant

Code Sample

No response

Logs

See PR https://github.com/fluttercommunity/plus_plugins/pull/2668

Flutter Doctor

None

Checklist before submitting a bug

  • I searched issues in this repository and couldn't find such bug/problem
  • I Google'd a solution and I couldn't find it
  • I searched on StackOverflow for a solution and I couldn't find it
  • I read the README.md file of the plugin
  • I'm using the latest version of the plugin
  • All dependencies are up to date with flutter pub upgrade
  • I did a flutter clean
  • I tried running the example project
@miquelbeltran miquelbeltran added bug Something isn't working triage labels Mar 11, 2024
@miquelbeltran miquelbeltran self-assigned this Mar 11, 2024
@miquelbeltran miquelbeltran added connectivity_plus Connectivity Plus android and removed triage labels Mar 11, 2024
@vbuberen
Copy link
Collaborator

I would like to handle it myself as I found one more bug with current main state of the plugin. Will open a new bug shortly and mention this issue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working connectivity_plus Connectivity Plus
Projects
None yet
2 participants