Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device_info_plus): Add iOS Privacy Info #2582

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

miquelbeltran
Copy link
Member

Description

  • Add PrivacyInfo to podspec of Device Info Plus

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran merged commit 34fe31e into main Feb 12, 2024
19 checks passed
@miquelbeltran miquelbeltran deleted the 2447-device_info_plus branch February 12, 2024 07:56
@victor-kotov
Copy link

Hi, @miquelbeltran could you please provide your thoughts re: if the empty PrivacyInfo.xcprivacy actually follow the Apple's guideline for API declaration? As far as I understand developers should provide NSPrivacyAccessedAPIType with NSPrivacyAccessedAPITypeReasons, not just empty plist 🤔 This question is general one as it looks like common "PR fix" across the Flutter packages and I'm just going by the list of these provided by Apple here https://developer.apple.com/support/third-party-SDK-requirements/ and device_info_plus at the top of my packages subset

@victor-kotov
Copy link

Eg from WWDC video https://developer.apple.com/wwdc23/10060?time=578

image

@miquelbeltran
Copy link
Member Author

As explained here, I couldn't find the use of any "Required API" by the plugin: #2447 (comment) that's why the privacy manifest NSPrivacyAccessedAPIType array is empty.

I am currently not developing iOS apps, so I have no way to verify this. If you are still facing issues, please fork the project, do the appropriated changes and report back, I'll be very interested to know!

hoanglm-guide-vn pushed a commit to guide-inc-org/guide-flutter_plus_plugins that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants