feat: duplicate offset taking into account snap #1283
+21
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If snap is activated, the offset is one exactly the size of one grid element, and if not, uses the previous value.
flxzt
reviewed
Nov 21, 2024
| self.translate_strokes_images(&new_selected, Stroke::IMPORT_OFFSET_DEFAULT); | ||
| // check if snap position is activated or not here | ||
| let offset = if snap_mode { | ||
| pattern_size |
There was a problem hiding this comment.
It often is the case that the selection is not snapped to the grid even when snap_positions is active.
It would be better if the logic does not simply use the grid's size as offset but actively snap the duplicated selection
to the grid when it is active (maybe "default offset" + nearest grid edge?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If snap is activated, the offset is one exactly the size of one grid element, and if not, uses the previous value.
Fixes #1245
We could do fancier things there. Always take into account the grid size (but switch based on whether the grid is visible or not). Or do an offset based on content (find a place that does not overlap with what's already there if possible)