Translate access token instead of id token to gRPC backend in Flyte Admin HTTP middleware #5979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Parraga <[email protected]>
Sovietaced
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5979 +/- ##
==========================================
+ Coverage 33.09% 36.90% +3.80%
==========================================
Files 1013 1310 +297
Lines 107489 131381 +23892
==========================================
+ Hits 35570 48480 +12910
- Misses 68767 78687 +9920
- Partials 3152 4214 +1062
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
following up in dm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #5978
Why are the changes needed?
See #5978
What changes were proposed in this pull request?
HTTP middleware translates session cookies into gRPC metadata containing the access token as opposed to the id token
Note: This has a subtle side effect that with blanket authorization the access token must include the
allscope.How was this patch tested?
Unit tests
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link