Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DeviceCodeAuthenticator does not support refresh tokens #6044

Open
2 tasks done
Sovietaced opened this issue Nov 21, 2024 · 0 comments · May be fixed by flyteorg/flytekit#2947
Open
2 tasks done

[BUG] DeviceCodeAuthenticator does not support refresh tokens #6044

Sovietaced opened this issue Nov 21, 2024 · 0 comments · May be fixed by flyteorg/flytekit#2947
Assignees
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers

Comments

@Sovietaced
Copy link
Contributor

Describe the bug

When using flytekit with the deviceFlow auth type refresh tokens are not stored in the keyring and thus not used. This makes it so folks have to re-login every day (or however long the access token lasts for).

https://github.com/flyteorg/flytekit/blob/2e40e76d8a5614a7eedcac8399ca877e64612640/flytekit/clients/auth/authenticator.py#L311-L312

Expected behavior

Flytekit uses refresh tokens and does not prompt a login when the access token expires.

Additional context to reproduce

No response

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@Sovietaced Sovietaced added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Nov 21, 2024
@Sovietaced Sovietaced self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

1 participant