-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Edit this page links are not working for Flyte Documentation #4109
Comments
Thank you for opening your first issue here! 🛠 |
@samhita-alla Could you please assign it to me so that i can work on it! |
Hello @samhita-alla, please assign this issue to me as I have already worked on this kind of problem in past and has a great experience. |
@itssiddhantjain I am currently working on this issue ans will add a PR to close the same. Kindly work on another issue! |
@itssiddhantjain Mate she has already assigned the issue to me and like i have already stated earlier that i am working on it...so please find another issue to work on and not spam messages on a already assigned issue! |
@itssiddhantjain Open-source contributions are mainly about collaboration, not about fighting for issues. You can always open a new issue if you've found any or contribute to the ones which are not yet assigned to anyone. It's clearly seen that OP wants to fix a bug he discovered and also is assigned to do the same. Multiple people can be assigned if it's a bigger issue or PR which requires many to collaborate. I hope you understand mate. |
@Smartmind12, are you working on creating a PR for this issue? |
Heyy @samhita-alla i have been busy but i will surely complete it with tomorrow or max day after! |
@samhita-alla I have also done this, can I send a PR if possible? |
@samhita-alla I am trying to spin up the docs website on gitpod however the website is not spinning up so can you provide me the code to run the website locally? |
@Smartmind12 you should be able to run the website locally by 1. pip install docs-requirements.txt on a venv with Python < 3.11 and 2. make -C /rsts HTML. The contribution guide needs to be updated with better instructions to do so, but these steps are what I follow to test the code when contributing to docs |
Thanks for the help… i will try the same and let you know! |
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. |
Describe the bug
The "Edit this page" icon is not working as on clicking it takes you to a "File not found folder" instead of taking you to the correct path of the file. This invalid links has been enconuntered for many of the pages in the Flyte Documentation.
Expected behavior
The correct behaviour is that when a user clicks on the "Edit the Page" Pencil icon, then the user is taken to the correct repository in the github environment to edit/contribute changes to the documentation.
Additional context to reproduce
No response
Screenshots
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: