Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added item unavailable until re-enabling extension #15

Open
Eagle3386 opened this issue Sep 6, 2019 · 1 comment
Open

Added item unavailable until re-enabling extension #15

Eagle3386 opened this issue Sep 6, 2019 · 1 comment

Comments

@Eagle3386
Copy link
Contributor

Eagle3386 commented Sep 6, 2019

Adding a new item under moz-extension://db1d30dc-3f4f-43a1-8b7b-77d1b74edee4/preferences.html -> Edit Menu won't make it available within the context menu afterwards.

Clicking Apply or even restarting Firefox does not resolve the issue either.
Only pressing CTRL+SHIFT+A, clicking •••, then Disable, then ••• again and finally Enable let's the newly added item show up.

Is there some way to inform Firefox of changes to an addon's provided context menu entry's sub-entries?
Kinda dirty hack, i. e. "disable->re-enable", is either forbidden right away or probably will be in the future.

I'd happily assist in fixing this if I'm pointed in the right direction. 😉

@fnxweb
Copy link
Owner

fnxweb commented Sep 6, 2019

Yeah, I noticed another setting recently that didn't take immediately.

It did all work originally, so there must have been a change under the hood that's borked it. Suspect a threading race condition (it's all asychronous now).

Actually, now I type this, it's likely the [URL Link] message that's sent out internally when prefs are saved to the other bits of the extension so they know that things have changed. If that's now going AWOL it could explain this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants