From e27501607579edd4371e4d107e969b9b169d6769 Mon Sep 17 00:00:00 2001 From: Zak Burke Date: Fri, 22 Dec 2023 06:36:32 -0500 Subject: [PATCH] STRWEB-105 lock favicons to v7.1.4 to avoid build failures (#135) `favicons` `v7.1.5` bumps `sharp` from `v0.32.6` to `v0.33.1` and ain't nothin' building anymore. See also https://github.com/itgalaxy/favicons/issues/448. Jenkins errors look like ``` /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:656 throw new Error( ^ Error: Could not find the npm peerDependency "favicons". Please run: npm i favicons - or - yarn add favicons Error: Could not load the "sharp" module using the linux-x64 runtime Possible solutions: - Ensure optional dependencies can be installed: npm install --include=optional sharp yarn add sharp --ignore-engines - Ensure your package manager supports multi-platform installation: See https://sharp.pixelplumbing.com/install#cross-platform - Add platform-specific dependencies: npm install --os=linux --cpu=x64 sharp npm install --force @img/sharp-linux-x64 - Consult the installation documentation: See https://sharp.pixelplumbing.com/install at loadFaviconsLibrary (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:656:11) at #generateFaviconsWebapp (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:454:26) at #generateFavicons (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:376:44) at /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/index.js:164:42 at /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/favicons-webpack-plugin/src/cache.js:150:5 at CacheFacade.providePromise (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/webpack/lib/CacheFacade.js:341:24) Node.js v18.17.1 error Command failed with exit code 1. ``` and similar errors occur in local development builds in other OSes. Refs STRWEB-105 (cherry picked from commit 7b54dd8efd2ac5b91f67983ff122a0e7e95a7ea5) --- CHANGELOG.md | 4 ++++ package.json | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5c3bfeb..df82a25 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Change history for stripes-webpack +## 5.0.2 IN PROGRESS + +* Lock `favicons` to `7.1.4` due to build failures. Refs STRWEB-105. + ## [5.0.1](https://github.com/folio-org/stripes-webpack/tree/v5.0.1) (2023-11-06) [Full Changelog](https://github.com/folio-org/stripes-webpack/compare/v5.0.0...v5.0.1) diff --git a/package.json b/package.json index df9ad2a..e8b51ea 100644 --- a/package.json +++ b/package.json @@ -45,7 +45,7 @@ "debug": "^4.0.1", "esbuild-loader": "~3.0.1", "express": "^4.14.0", - "favicons": "^7.1.2", + "favicons": "7.1.4", "favicons-webpack-plugin": "^6.0.0", "handlebars": "^4.7.7", "handlebars-loader": "^1.7.1",