UIU-2951: change disabled button style #2568
Conversation
| .disabledButton { | ||
| color: #000000; | ||
| cursor: not-allowed; | ||
| opacity: 0.65; | ||
| } |
There was a problem hiding this comment.
We provide disabled-button styling already so I am not confident we need local handling for this, but I am confident that we don't need it twice (I'm lookin' at you, RequestFeeFineBlockButtons.css).
If you believe we do need a local style, (1) please explain why and (2) let's find a place where we can specify it once and share it.
There was a problem hiding this comment.
Hello @zburke. I will check the component docs again. Indeed, we have handled styling for the disabled button already. However, I don't think we have handled it for a tags in. the button component. In my case, since the Button component has a href or to property, the elements have been used as anchor tags rather than buttons.
There was a problem hiding this comment.
I have created PR regarding to the issue here folio-org/stripes-components#2142
Do you want me to hide them instead of disable them? |
yes |
|
Kudos, SonarCloud Quality Gate passed! |
Purpose
UIU-2951: change disabled button style
Approach
Screen.Recording.2023-10-09.at.7.19.23.PM.mov
TODOS and Open Questions
Learning
Pre-Merge Checklist
Before merging this PR, please go through the following list and take appropriate actions.
If there are breaking changes, please STOP and consider the following:
Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.
While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.