Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Node 12 #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Node 12 #43

wants to merge 1 commit into from
+40 −26

Conversation

implausible
Copy link
Contributor

Fixes #42.

@polyrhythmatic polyrhythmatic mentioned this pull request Dec 18, 2019
Open
agata added a commit to agata/font-manager that referenced this pull request Jan 9, 2020
@agata
Support Node 12
784f108 
foliojs#43
@ye4241
Copy link

ye4241 commented Jan 13, 2020

Works great! Please merge it...

@implausible
Copy link
Contributor Author

If you need this right away, https://www.npmjs.com/package/font-scanner has the fixes in it.

@ryohorie
Copy link

Please merge it..

@ye4241
Copy link

ye4241 commented Jan 16, 2020

If you need this right away, https://www.npmjs.com/package/font-scanner has the fixes in it.

the font-scanner do not include index.d.ts directly and still need to be done in the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't compile with electron
4 participants
@implausible @ye4241 @ryohorie @devongovett