From 17e062caa701eb8a391b8b52d772d64137477da4 Mon Sep 17 00:00:00 2001
From: "Steven R. Loomis" <srl295@gmail.com>
Date: Mon, 8 Apr 2024 08:01:21 -0500
Subject: [PATCH] fix: StringT: assume unknown encodings are 1-byte (#62)

- add a test for 'x-mac-roman'
- add two utf-16 alias names
- if an encoding is otherwise unknown, assume 1-byte length
(this matches prior behavior)

Fixes: #60
---
 src/String.js  | 6 +++++-
 test/String.js | 6 ++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/String.js b/src/String.js
index dd4b264..a066b12 100644
--- a/src/String.js
+++ b/src/String.js
@@ -98,12 +98,16 @@ function encodingWidth(encoding) {
       return 1;
     case 'utf16le':
     case 'utf16-le':
+    case 'utf-16be':
+    case 'utf-16le':
     case 'utf16be':
     case 'utf16-be':
     case 'ucs2':
       return 2;
     default:
-      throw new Error('Unknown encoding ' + encoding);
+      //TODO: assume all other encodings are 1-byters
+      //throw new Error('Unknown encoding ' + encoding);
+      return 1;
   }
 }
 
diff --git a/test/String.js b/test/String.js
index e7287a4..a5bbe14 100644
--- a/test/String.js
+++ b/test/String.js
@@ -52,6 +52,12 @@ describe('String', function() {
       const string = new StringT(null, 'utf16le');
       assert.equal(string.fromBuffer(Buffer.from('🍻', 'utf16le')), '🍻');
     });
+
+    it('should decode x-mac-roman', function() {
+      const string = new StringT(null, 'x-mac-roman');
+      const buf = new Uint8Array([0x8a, 0x63, 0x63, 0x65, 0x6e, 0x74, 0x65, 0x64, 0x20, 0x63, 0x68, 0x87, 0x72, 0x61, 0x63, 0x74, 0x65, 0x72, 0x73]);
+      assert.equal(string.fromBuffer(buf), 'äccented cháracters');
+    })
   });
 
   describe('size', function() {