From 0b1694423ed41c839608eb6e42bcb7cbdb2b14de Mon Sep 17 00:00:00 2001 From: Simon Cozens Date: Mon, 4 Mar 2024 13:22:45 +0000 Subject: [PATCH] Add rationale for production_glyphs_similarity com.google.fonts/check/production_glyphs_similarity On the Google Fonts Profile. (PR #4570) --- CHANGELOG.md | 1 + Lib/fontbakery/checks/googlefonts/hosted.py | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 55ce9946d9..0247299a2c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -49,6 +49,7 @@ A more detailed list of changes is available in the corresponding milestones for - **[com.google.fonts/check/metadata/nameid/copyright]:** Added rationale. (PR #4570) - **[com.google.fonts/check/has_ttfautohint_params]:** Added rationale. (PR #4570) - **[com.google.fonts/check/smart_dropout]:** Improve rationale with better fixing instructions. (PR #4570) + - **[com.google.fonts/check/production_glyphs_similarity]:** Added rationale. (PR #4570) #### On the FontValidator profile - **[com.google.fonts/check/fontvalidator]:** Added rationale. (PR #4570) diff --git a/Lib/fontbakery/checks/googlefonts/hosted.py b/Lib/fontbakery/checks/googlefonts/hosted.py index 091392ea37..adcfc9a3ae 100644 --- a/Lib/fontbakery/checks/googlefonts/hosted.py +++ b/Lib/fontbakery/checks/googlefonts/hosted.py @@ -55,6 +55,12 @@ def com_google_fonts_check_version_bump( id="com.google.fonts/check/production_glyphs_similarity", conditions=["api_gfonts_ttFont"], proposal="legacy:check/118", + rationale=""" + We check that the glyphs in the font are similar to the glyphs in the + version hosted on fonts.google.com. We do not expect updated fonts to + have exactly the same glyphs as the previous version, but we do expect + the changes to be minimal. + """, ) def com_google_fonts_check_production_glyphs_similarity( ttFont, api_gfonts_ttFont, config