From 5f280ab65610ba379e274c64f4b37c4a0da83f33 Mon Sep 17 00:00:00 2001 From: Simon Cozens Date: Mon, 4 Mar 2024 13:19:35 +0000 Subject: [PATCH] Add rationale for has_ttfautohint_params com.google.fonts/check/has_ttfautohint_params On the Google Fonts Profile. (PR #4570) --- CHANGELOG.md | 1 + Lib/fontbakery/checks/googlefonts/hinting.py | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a6e30d0f14..f577dce81d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -47,6 +47,7 @@ A more detailed list of changes is available in the corresponding milestones for - **[com.google.fonts/check/metadata/canonical_weight_value]:** Added rationale. (PR #4570) - **[com.google.fonts/check/metadata/copyright_max_length]:** Added rationale. (PR #4570) - **[com.google.fonts/check/metadata/nameid/copyright]:** Added rationale. (PR #4570) + - **[com.google.fonts/check/has_ttfautohint_params]:** Added rationale. (PR #4570) #### On the FontValidator profile - **[com.google.fonts/check/fontvalidator]:** Added rationale. (PR #4570) diff --git a/Lib/fontbakery/checks/googlefonts/hinting.py b/Lib/fontbakery/checks/googlefonts/hinting.py index 8011ba43b4..f5d26ead81 100644 --- a/Lib/fontbakery/checks/googlefonts/hinting.py +++ b/Lib/fontbakery/checks/googlefonts/hinting.py @@ -193,6 +193,12 @@ def com_google_fonts_check_hinting_impact(font): @check( id="com.google.fonts/check/has_ttfautohint_params", proposal="https://github.com/fonttools/fontbakery/issues/1773", + rationale=""" + It is critically important that all static TTFs in the API which + were autohinted with ttfautohint store their TTFAutohint args in + the 'name' table, so that an automated solution can be made to + replicate the hinting on subsets, etc. + """, ) def com_google_fonts_check_has_ttfautohint_params(ttFont): """Font has ttfautohint params?"""