From e9939bb1fdde375d44444482670343b75e0a7486 Mon Sep 17 00:00:00 2001 From: mingxuanzhang Date: Mon, 8 Jul 2024 12:02:30 -0700 Subject: [PATCH 1/7] chore: add test for sfdx-project.json --- .github/workflows/coreE2E.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/coreE2E.yml b/.github/workflows/coreE2E.yml index ee920bfc9b..3967c21771 100644 --- a/.github/workflows/coreE2E.yml +++ b/.github/workflows/coreE2E.yml @@ -75,6 +75,11 @@ on: required: false default: true type: boolean + sfdxProjectJson: + description: 'sfdx-project.json' + required: false + default: true + type: boolean vscodeVersion: description: 'VSCode Version' required: false @@ -136,6 +141,16 @@ jobs: vscodeVersion: ${{ inputs.vscodeVersion || '1.85.2' }} runId: ${{ inputs.runId }} + sfdxProjectJson: + if: ${{ inputs.templates }} + uses: ./.github/workflows/runE2ETest.yml + secrets: inherit + with: + automationBranch: ${{ inputs.automationBranch }} + testToRun: 'sfdxProjectJson.e2e.ts' + vscodeVersion: ${{ inputs.vscodeVersion || '1.85.2' }} + runId: ${{ inputs.runId }} + slack_success_notification: if: ${{ success() }} needs: From 35ac9ea983d7044964c69465df12fe24b8d5e2e3 Mon Sep 17 00:00:00 2001 From: mingxuanzhang Date: Mon, 8 Jul 2024 12:14:01 -0700 Subject: [PATCH 2/7] chore: make default true --- .github/workflows/coreE2E.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coreE2E.yml b/.github/workflows/coreE2E.yml index 3967c21771..6a8fe8de78 100644 --- a/.github/workflows/coreE2E.yml +++ b/.github/workflows/coreE2E.yml @@ -142,7 +142,7 @@ jobs: runId: ${{ inputs.runId }} sfdxProjectJson: - if: ${{ inputs.templates }} + if: ${{ true }} uses: ./.github/workflows/runE2ETest.yml secrets: inherit with: From 3106681f553c971f7c182351ca59495455372622 Mon Sep 17 00:00:00 2001 From: mingxuanzhang Date: Mon, 8 Jul 2024 12:39:52 -0700 Subject: [PATCH 3/7] chore: if condition --- .github/workflows/coreE2E.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coreE2E.yml b/.github/workflows/coreE2E.yml index 6a8fe8de78..ec788de859 100644 --- a/.github/workflows/coreE2E.yml +++ b/.github/workflows/coreE2E.yml @@ -142,7 +142,7 @@ jobs: runId: ${{ inputs.runId }} sfdxProjectJson: - if: ${{ true }} + if: ${{ inputs.sfdxProjectJson }} uses: ./.github/workflows/runE2ETest.yml secrets: inherit with: From 30e371012fda10e742247af6b6c89b043ab88c6e Mon Sep 17 00:00:00 2001 From: mingxuanzhang Date: Mon, 8 Jul 2024 12:50:04 -0700 Subject: [PATCH 4/7] chore: if condition --- .github/workflows/coreE2E.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coreE2E.yml b/.github/workflows/coreE2E.yml index ec788de859..6a8fe8de78 100644 --- a/.github/workflows/coreE2E.yml +++ b/.github/workflows/coreE2E.yml @@ -142,7 +142,7 @@ jobs: runId: ${{ inputs.runId }} sfdxProjectJson: - if: ${{ inputs.sfdxProjectJson }} + if: ${{ true }} uses: ./.github/workflows/runE2ETest.yml secrets: inherit with: From 31b59da8f9c029e6d962edcb0369a7fe644ee09f Mon Sep 17 00:00:00 2001 From: mingxuanzhang Date: Thu, 11 Jul 2024 10:45:34 -0700 Subject: [PATCH 5/7] chore: if statement --- .github/workflows/coreE2E.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coreE2E.yml b/.github/workflows/coreE2E.yml index 6a8fe8de78..ec788de859 100644 --- a/.github/workflows/coreE2E.yml +++ b/.github/workflows/coreE2E.yml @@ -142,7 +142,7 @@ jobs: runId: ${{ inputs.runId }} sfdxProjectJson: - if: ${{ true }} + if: ${{ inputs.sfdxProjectJson }} uses: ./.github/workflows/runE2ETest.yml secrets: inherit with: From 7583850e4738b7c9eed85507037656c391194b16 Mon Sep 17 00:00:00 2001 From: Daphne Yang Date: Tue, 6 Aug 2024 09:56:51 -0400 Subject: [PATCH 6/7] fix: default vscode version is stable --- .github/workflows/coreE2E.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coreE2E.yml b/.github/workflows/coreE2E.yml index a010681d16..0e2ce61cb7 100644 --- a/.github/workflows/coreE2E.yml +++ b/.github/workflows/coreE2E.yml @@ -148,7 +148,7 @@ jobs: with: automationBranch: ${{ inputs.automationBranch }} testToRun: 'sfdxProjectJson.e2e.ts' - vscodeVersion: ${{ inputs.vscodeVersion || '1.85.2' }} + vscodeVersion: ${{ inputs.vscodeVersion }} runId: ${{ inputs.runId }} slack_success_notification: From 1319e7bf0b311b91bd79ddff1823f7ab026cacf2 Mon Sep 17 00:00:00 2001 From: Daphne Yang Date: Tue, 6 Aug 2024 10:02:49 -0400 Subject: [PATCH 7/7] fix: sfdxProjectJson E2E can be manually dispatched --- .github/workflows/coreE2E.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/coreE2E.yml b/.github/workflows/coreE2E.yml index 0e2ce61cb7..bf576e98f3 100644 --- a/.github/workflows/coreE2E.yml +++ b/.github/workflows/coreE2E.yml @@ -33,6 +33,11 @@ on: required: false default: true type: boolean + sfdxProjectJson: + description: 'sfdx-project.json' + required: false + default: true + type: boolean vscodeVersion: description: 'VSCode Version' required: false