Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding component modal ref so components can redraw within a modal. #111

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

travist
Copy link
Member

@travist travist commented Nov 28, 2024

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-8746

Description

Previously we had to implement several hacks within our renderer to allow for Nested Wizards to show and function within a Modal. The reason it was problematic is because it could not redraw within the modal since there is no reference that can be used to bind the element of the nested wizard against. This solves that problem.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit f8557ec into main Dec 9, 2024
5 checks passed
@brendanbond brendanbond deleted the component-modal-content branch December 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants