Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Validation does not disappear with formio 5.0.0-x #5457

Closed
ralfeis opened this issue Jan 14, 2024 · 6 comments · Fixed by formio/core#31
Closed

Required Validation does not disappear with formio 5.0.0-x #5457

ralfeis opened this issue Jan 14, 2024 · 6 comments · Fixed by formio/core#31

Comments

@ralfeis
Copy link

ralfeis commented Jan 14, 2024

Hi,

if I use the newest version 5.0.0-rc38, then the "required" validation behaves different to the 4.6 version of formio.
grafik

The example is a "true","false" decision which must be selected (required validation)
If "no" is selected, then the required validation does not disappear.

Here is a simple example to test:
https://stackblitz.com/edit/js-o27pu6?file=index.html,package.json

Best regards

@jeriah-formio
Copy link
Collaborator

jeriah-formio commented Apr 3, 2024

@ralfeis
This issue seems to be resolved on 5.0.0-rc.39

@ralfeis
Copy link
Author

ralfeis commented Apr 13, 2024

Hi @jeriah-formio,

thanks for your feedback.
I updated the test project: https://stackblitz.com/edit/js-o27pu6?file=index.html,package.json
to the latest Formio (5.0.0-rc.42), but the error is still there.
The pull request of formio/core#31 must be merged, then it will be fixed.

Best regards

@lane-formio
Copy link
Contributor

lane-formio commented Apr 15, 2024

Just got get this into our workflow I've created an internal ticket: FIO-8221

Thanks for the contribution! @brendanbond will stay on top of this

@lane-formio
Copy link
Contributor

lane-formio commented Apr 19, 2024

The fix had to be reverted as it broke validation for checkboxes. I'm going to go ahead and re-open the issue.

An internal ticket has been logged to track this issue: FIO-8221

@lane-formio lane-formio reopened this Apr 19, 2024
@lane-formio
Copy link
Contributor

@ralfeis
I have logged a ticket for internal reference, but it is not being prioritized at the moment. If you'd like to explore another fix that will work for both radio and checkboxes I'd be happy to have get it reviewed.

@ralfeis
Copy link
Author

ralfeis commented Jun 18, 2024

Hi formio team,

this issue can be closed. You have fixed it with this pull request: formio/core#88
Many thanks for the great work!

Best regards
Ralf

@ralfeis ralfeis closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants