Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: enable only the animations we need #153

Open
yojona opened this issue Aug 8, 2023 · 5 comments
Open

feature request: enable only the animations we need #153

yojona opened this issue Aug 8, 2023 · 5 comments

Comments

@yojona
Copy link

yojona commented Aug 8, 2023

It would be great to be able to pass the animations we need, like:

useAutoAnimate(['add', 'remove']);

My app uses react-beautiful-dnd and it doesn't work very well with 'remain', so in cases like this when we use other libraries with animations that might interfere with the behavior of the element, this function will be really useful.

@yojona
Copy link
Author

yojona commented Aug 8, 2023

I think this #118 is related

@drmercer
Copy link

drmercer commented Sep 1, 2023

@yojona I use a similar library (dndkit) and solved this issue by disabling autoAnimate while I update the DOM after a dropped drag. It's a little tricky to get right, but it works, and as a nice side-effect, it preserves the "remain" animation when the list order is changing for other reasons.

@felipedeboni
Copy link

It would be nice to have a bit more control over it and it's defaults.

Eg.: I want to override just add animation and keep others as default.

In theory we could modify the config to have: onAdd, onRemove, onRemain and if omitted it would pick the defaults for it. Probably solves two things at once, if user pass false to any of these, than it wouldn't animate that action.

@wangyinyuan
Copy link

wangyinyuan commented Oct 29, 2024

So is there any easy way to do this now?

I'm also trying to disable the add and remove animations and just keep the remain default animation.

@felipedeboni
Copy link

So is there any easy way to do this now?

I'm also trying to disable the add and remove animations and just keep the remain default animation.

I ended up forking it on our private monorepo and added the callbacks I said earlier, most likely the pull request wasn't going to be accepted so I didn't even tried to make one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants