Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustls-mbedcrypto-provider #2

Merged
merged 7 commits into from
Nov 3, 2023
Merged

Add rustls-mbedcrypto-provider #2

merged 7 commits into from
Nov 3, 2023

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Oct 31, 2023

No description provided.

@Taowyoo Taowyoo force-pushed the yx/crypto-provider branch 2 times, most recently from 1744a35 to 855e807 Compare October 31, 2023 22:05
@Taowyoo Taowyoo requested a review from s-arash October 31, 2023 22:52
@Taowyoo Taowyoo marked this pull request as draft November 1, 2023 15:54
@Taowyoo Taowyoo force-pushed the yx/crypto-provider branch from 0c8f8a3 to 35d83a8 Compare November 1, 2023 22:13
@Taowyoo Taowyoo marked this pull request as ready for review November 1, 2023 22:13
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

rustls-mbedcrypto-provider/tests/server_cert_verifier.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/hash.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/error.rs Show resolved Hide resolved
rustls-mbedcrypto-provider/src/hmac.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/lib.rs Show resolved Hide resolved
rustls-mbedcrypto-provider/src/hmac.rs Outdated Show resolved Hide resolved
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Nov 2, 2023

The fix for failed macos build need to wait fortanix/rust-mbedtls#333 to be merged.

@Taowyoo Taowyoo requested a review from s-arash November 2, 2023 18:25
@Taowyoo Taowyoo force-pushed the yx/crypto-provider branch from c6e7826 to 3a8b96a Compare November 2, 2023 23:15
@Taowyoo Taowyoo enabled auto-merge November 2, 2023 23:19
@Taowyoo Taowyoo self-assigned this Nov 2, 2023
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Nov 2, 2023

I just rearranged the commit, so reviewers could just review the important part in commit: 9bd05a6

rustls-mbedcrypto-provider/Cargo.toml Show resolved Hide resolved
rustls-mbedcrypto-provider/src/kx.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/kx.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/kx.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/kx.rs Show resolved Hide resolved
rustls-mbedcrypto-provider/src/tls13.rs Show resolved Hide resolved
rustls-mbedcrypto-provider/src/tls12.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/tls12.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/tls12.rs Outdated Show resolved Hide resolved
rustls-mbedcrypto-provider/src/tls12.rs Outdated Show resolved Hide resolved
@Taowyoo Taowyoo requested a review from s-arash November 3, 2023 18:13
Copy link
Collaborator

@s-arash s-arash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Taowyoo Taowyoo added this pull request to the merge queue Nov 3, 2023
Merged via the queue into master with commit 351ee99 Nov 3, 2023
11 checks passed
@Taowyoo Taowyoo deleted the yx/crypto-provider branch November 3, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants