From 2233fa921293d3718adcac4bef043652c91870df Mon Sep 17 00:00:00 2001 From: Martin Charles Date: Wed, 22 Aug 2018 13:56:26 -0400 Subject: [PATCH 1/3] Removed build/music From Deploy Artifacts Step --- .circleci/config.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index c185c51..dd6838e 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -46,10 +46,6 @@ jobs: name: Build command: yarn build - - run: - name: Remove Mock Media Files - command: rm -rf build/music - - run: name: Compress Build Artifacts command: tar czvf forte-web.tar.gz -C build . From 7f9443af87439e94dad678f8c8d222299604b14e Mon Sep 17 00:00:00 2001 From: Martin Charles Date: Wed, 22 Aug 2018 14:52:52 -0400 Subject: [PATCH 2/3] Fixed Deploy Artifacts Running On PRs It can't and shouldn't run on PRs. --- .circleci/config.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.circleci/config.yml b/.circleci/config.yml index dd6838e..961c2c1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -110,6 +110,13 @@ workflows: requires: - test + filters: + # Disable on PR builds. Pull Request builds have branch names of + # pull/. If this changes, our builds will fail + # (without leaking our secrets) since secrets aren't exposed to PR + # builds. + only: /^(?!pull\/).*$/ + - deploy_surge: requires: - test From 55744071162350c32b1871472a29cb528fa36370 Mon Sep 17 00:00:00 2001 From: Martin Charles Date: Wed, 22 Aug 2018 14:57:27 -0400 Subject: [PATCH 3/3] Fixed CircleCI Configuration --- .circleci/config.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 961c2c1..a69a645 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -115,7 +115,8 @@ workflows: # pull/. If this changes, our builds will fail # (without leaking our secrets) since secrets aren't exposed to PR # builds. - only: /^(?!pull\/).*$/ + branches: + only: /^(?!pull\/).*$/ - deploy_surge: requires: