Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image preview functionality in terminal? #303

Open
virtualritz opened this issue Sep 13, 2024 · 2 comments
Open

Add image preview functionality in terminal? #303

virtualritz opened this issue Sep 13, 2024 · 2 comments

Comments

@virtualritz
Copy link

virtualritz commented Sep 13, 2024

Specifically using the viuer crate.

I am working on OpenImageIO Rust bindings that already support Into<image::DynamicImage> (automatic color space conversion to sRGB using an active OCIO color config).
An image::DynamicImage can be directly displayed via viuer. 😁

@doubleailes
Copy link
Collaborator

Hi @virtualritz ,

Thanks a lot for this suggestion. This lib is really interesting.
I try to decouple the core packing part from the command line tool for the past few weeks without any success in my quest of performance.

Thanks a lot for your contribution to the industry ( Atomkraft <3 ), i will check more closely the OIIO Rust bindings.
But as Fortiche is running Windows, i’m trying to stay away from Cpp bindings to ensure that fls is easy to compile at the studio.

Do you know any plan to have a pure Rust OIIO?

P

@virtualritz
Copy link
Author

virtualritz commented Oct 2, 2024

I guess another option is to use the image crate.

The tricky part is for interesting formats like OpenEXR to display correctly. Let's say you have an OpenEXR in ACEScg space. How do you get that to display 'usefully' in non-linear sRGB, in the terminal?

OIIO handles all this as it integrates OCIO.

A Rust port of OCIO would probably be more interesting in that regard.

Maybe the display stuff could be behind a feature flag?

Also note that the OIIO crate will find an existing OIIO installation during build. I think on Windows that is one chocolatery command away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants