Fix incompatibility with simplecov < 0.18 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for posting the solution, which works but is still not merged. If you need a simple local fix, just monkeypatch via require 'simplecov-lcov'
SimpleCov.formatter = SimpleCov::Formatter::LcovFormatter
if ! SimpleCov.respond_to?(:branch_coverage?)
module SimpleCov
def self.branch_coverage?
false
end
end
end
SimpleCov::Formatter::LcovFormatter.config do |c|
c.output_directory = 'coverage' # default: "coverage/lcov"
end |
lnxbil
added a commit
to lnxbil/vscode-code-coverage
that referenced
this pull request
Apr 20, 2022
With `bashcov` and the following configuration for `simplecov` can you get coverage reports for you shell scripts.
```ruby
# gem install simplecov-lcov simplecov-console
require 'simplecov-lcov'
require 'simplecov-console'
SimpleCov.start do
add_filter %r{^/.git}
end
# Monkeypatch
# fortissimo1997/simplecov-lcov#25
if ! SimpleCov.respond_to?(:branch_coverage?)
module SimpleCov
def self.branch_coverage?
false
end
end
end
SimpleCov::Formatter::LcovFormatter.config.report_with_single_file = true
SimpleCov::Formatter::LcovFormatter.config do |c|
c.output_directory = 'coverage' # default: "coverage/lcov"
c.lcov_file_name = 'lcov.info'
end
SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
SimpleCov::Formatter::LcovFormatter,
SimpleCov::Formatter::HTMLFormatter,
SimpleCov::Formatter::Console
])
```
markis
pushed a commit
to markis/vscode-code-coverage
that referenced
this pull request
Apr 20, 2022
With `bashcov` and the following configuration for `simplecov` can you get coverage reports for you shell scripts.
```ruby
# gem install simplecov-lcov simplecov-console
require 'simplecov-lcov'
require 'simplecov-console'
SimpleCov.start do
add_filter %r{^/.git}
end
# Monkeypatch
# fortissimo1997/simplecov-lcov#25
if ! SimpleCov.respond_to?(:branch_coverage?)
module SimpleCov
def self.branch_coverage?
false
end
end
end
SimpleCov::Formatter::LcovFormatter.config.report_with_single_file = true
SimpleCov::Formatter::LcovFormatter.config do |c|
c.output_directory = 'coverage' # default: "coverage/lcov"
c.lcov_file_name = 'lcov.info'
end
SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
SimpleCov::Formatter::LcovFormatter,
SimpleCov::Formatter::HTMLFormatter,
SimpleCov::Formatter::Console
])
```
markis
pushed a commit
to markis/vscode-code-coverage
that referenced
this pull request
Apr 22, 2022
With `bashcov` and the following configuration for `simplecov` can you get coverage reports for you shell scripts.
```ruby
# gem install simplecov-lcov simplecov-console
require 'simplecov-lcov'
require 'simplecov-console'
SimpleCov.start do
add_filter %r{^/.git}
end
# Monkeypatch
# fortissimo1997/simplecov-lcov#25
if ! SimpleCov.respond_to?(:branch_coverage?)
module SimpleCov
def self.branch_coverage?
false
end
end
end
SimpleCov::Formatter::LcovFormatter.config.report_with_single_file = true
SimpleCov::Formatter::LcovFormatter.config do |c|
c.output_directory = 'coverage' # default: "coverage/lcov"
c.lcov_file_name = 'lcov.info'
end
SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter.new([
SimpleCov::Formatter::LcovFormatter,
SimpleCov::Formatter::HTMLFormatter,
SimpleCov::Formatter::Console
])
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleCov.branch_coverage?was added in simplecov 0.18. When an older version of simplecov is installed, the lcov formatter dies in the middle of generating the output.Unfortunately this project's gemspec doesn't specify the version of simplecov that it requires. So the solution is to check for the existence of this method before calling it.
This doesn't fix release 0.8.0 of simplecov-lcov. So a project could still install an incompatible combination of simplecov and simplecov-lcov. But with this change in a newer release, they should end up with a compatible combination of the two packages.