Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp from 3.11.9 to 3.11.10 in /server #289

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2024

Bumps aiohttp from 3.11.9 to 3.11.10.

Release notes

Sourced from aiohttp's releases.

3.11.10

Bug fixes

  • Fixed race condition in :class:aiohttp.web.FileResponse that could have resulted in an incorrect response if the file was replaced on the file system during prepare -- by :user:bdraco.

    Related issues and pull requests on GitHub: #10101, #10113.

  • Replaced deprecated call to :func:mimetypes.guess_type with :func:mimetypes.guess_file_type when using Python 3.13+ -- by :user:bdraco.

    Related issues and pull requests on GitHub: #10102.

  • Disabled zero copy writes in the StreamWriter -- by :user:bdraco.

    Related issues and pull requests on GitHub: #10125.


Changelog

Sourced from aiohttp's changelog.

3.11.10 (2024-12-05)

Bug fixes

  • Fixed race condition in :class:aiohttp.web.FileResponse that could have resulted in an incorrect response if the file was replaced on the file system during prepare -- by :user:bdraco.

    Related issues and pull requests on GitHub: :issue:10101, :issue:10113.

  • Replaced deprecated call to :func:mimetypes.guess_type with :func:mimetypes.guess_file_type when using Python 3.13+ -- by :user:bdraco.

    Related issues and pull requests on GitHub: :issue:10102.

  • Disabled zero copy writes in the StreamWriter -- by :user:bdraco.

    Related issues and pull requests on GitHub: :issue:10125.


Commits
  • 0d7352a Release 3.11.10 (#10128)
  • 5ddff95 [PR #10125/d58d2c3d backport][3.11] Disable zero copy writes in the ``StreamW...
  • db5e6bb [PR #10122/703ce61 backport][3.11] Typing improvements for file responses (#1...
  • bcae561 [PR #10113/01302134 backport][3.11] Restore 304 performance after fixing `Fil...
  • 78473b9 [PR #10114/94569554 backport][3.11] Add 304 benchmark for FileResponse (#10115)
  • ae153ab [PR #10107/84bb77d1 backport][3.11] Use internal self._headers var in `File...
  • 07d1759 [PR #10101/678993a4 backport][3.11] Fix race in FileResponse if file is rep...
  • 23a4b31 [PR #10102/7557b03d backport][3.11] Fix deprecated calls to guess_type for ...
  • c41ffc7 [PR #10095/fcce1bf6 backport][3.11] Add a benchmark for web.FileResponse (#10...
  • 86bb6ad [PR #10088/29c3ca93 backport][3.11] Avoid calling len on the same data in the...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by Sourcery

Bump aiohttp from version 3.11.9 to 3.11.10 to incorporate bug fixes, including a race condition fix in FileResponse, replacement of deprecated mimetypes function calls, and disabling of zero copy writes in StreamWriter.

Bug Fixes:

  • Fix race condition in aiohttp.web.FileResponse that could result in incorrect responses if the file was replaced during preparation.
  • Replace deprecated call to mimetypes.guess_type with mimetypes.guess_file_type for Python 3.13+ compatibility.
  • Disable zero copy writes in StreamWriter to prevent potential issues.

Bumps [aiohttp](https://github.com/aio-libs/aiohttp) from 3.11.9 to 3.11.10.
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.11.9...v3.11.10)

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 9, 2024
Copy link

sourcery-ai bot commented Dec 9, 2024

Reviewer's Guide by Sourcery

This is a minor version bump of the aiohttp library from 3.11.9 to 3.11.10. The update includes several bug fixes, particularly around FileResponse handling, Python 3.13+ compatibility, and StreamWriter behavior.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update aiohttp dependency version
  • Fixes race condition in FileResponse when files are replaced during prepare
  • Updates mimetypes.guess_type call to be compatible with Python 3.13+
  • Disables zero copy writes in StreamWriter
  • Updates version from 3.11.9 to 3.11.10
server/requirements.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, dependabot[bot]!). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

@mariobehling mariobehling merged commit 5174d2d into development Dec 10, 2024
4 of 6 checks passed
@dependabot dependabot bot deleted the dependabot/pip/server/aiohttp-3.11.10 branch December 10, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant