Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails if connectrequesttimeout is used: seems it's not to be connectionrequesttimeout #3

Open
carehart opened this issue Feb 11, 2021 · 0 comments

Comments

@carehart
Copy link

There seems to be a change in the underlying httpclient, causing an error.

When I ran the tool passing in an arrayelement of connectrequesttimeout (as indicated in the readme and the code), it failed saying it was invalid. I looked and found that the method for the underlying requestbuilder is instead connect_ion_requesttimeout. I gather perhaps the httpclient api has changed over time.

I could have proposed a PR, but it would seem you may want to handle things any of several ways, from adding a new arg, to letting the old arg work (for backward compat) but have the code pass it as the value to the new arg, or perhaps determine what to do via a try/catch based on what the underlying httpclient class supports, or creating a different version of the CFC that might be version-specific and called dynamically based on detection of a new httpclient class. I just didn't want to presume any particular implementation that may appeal to you or not. :-)

So I'll leave it here for consideration by you or others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant