-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm: factory definition: Describe a list of variables #593
Conversation
Docs for 6a9aeee are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2341/docs/artifacts/html/index.html |
When set to ``1``, this variable configures the source code | ||
to avoid the LmP default packages under GPLv3. | ||
Reference: :ref:`ref-remove-gplv3`. | ||
* **ENABLE_PTEST**: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foundriesio/meta-lmp#1255 disabled the PTEST distro feauture so maybe it can also be droped from https://github.com/search?q=repo%3Afoundriesio%2Fci-scripts%20ENABLE_PTEST&type=code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, mostly related to commas. LGTM!
.. _def-containers: | ||
|
||
containers | ||
---------- | ||
|
||
Define the container's configuration, including some image configuration and target architecture. | ||
|
||
.. sidebar:: ``containers:`` Section Example | ||
|
||
.. code-block:: yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kprosise there is a "devel" in this code-block. I want to double check if it's intended. If it's not, I can remove it while on this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can if you want, or I can get to it when I do the cleanup of the reference manual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you had already cleaned those pages. I prefer to keep this for you, so. Thanks @kprosise
Signed-off-by: Daiane Angolini <[email protected]>
6a9aeee
to
d8a14f4
Compare
Docs for d8a14f4 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2342/docs/artifacts/html/index.html |
Readiness
Overview
Describe some variables and provide some references in a central place (the page where you see how to change the factory config file).