Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: factory definition: Describe a list of variables #593

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

angolini
Copy link
Collaborator

@angolini angolini commented Sep 5, 2023

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Describe some variables and provide some references in a central place (the page where you see how to change the factory config file).

@doanac
Copy link
Member

doanac commented Sep 5, 2023

When set to ``1``, this variable configures the source code
to avoid the LmP default packages under GPLv3.
Reference: :ref:`ref-remove-gplv3`.
* **ENABLE_PTEST**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foundriesio/meta-lmp#1255 disabled the PTEST distro feauture so maybe it can also be droped from https://github.com/search?q=repo%3Afoundriesio%2Fci-scripts%20ENABLE_PTEST&type=code

source/reference-manual/factory/factory-definition.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, mostly related to commas. LGTM!

source/reference-manual/factory/factory-definition.rst Outdated Show resolved Hide resolved
source/reference-manual/factory/factory-definition.rst Outdated Show resolved Hide resolved
source/reference-manual/factory/factory-definition.rst Outdated Show resolved Hide resolved
source/reference-manual/factory/factory-definition.rst Outdated Show resolved Hide resolved
.. _def-containers:

containers
----------

Define the container's configuration, including some image configuration and target architecture.

.. sidebar:: ``containers:`` Section Example

.. code-block:: yaml
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kprosise there is a "devel" in this code-block. I want to double check if it's intended. If it's not, I can remove it while on this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can if you want, or I can get to it when I do the cleanup of the reference manual.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you had already cleaned those pages. I prefer to keep this for you, so. Thanks @kprosise

@doanac
Copy link
Member

doanac commented Sep 6, 2023

@kprosise kprosise merged commit 51a8346 into foundriesio:main Sep 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants