Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exhaustion on 2024 rules assumes for Imperial even when "Use Metric" is checked #4215

Open
BrotherSharper opened this issue Sep 14, 2024 · 1 comment · May be fixed by #4893
Open

Exhaustion on 2024 rules assumes for Imperial even when "Use Metric" is checked #4215

BrotherSharper opened this issue Sep 14, 2024 · 1 comment · May be fixed by #4893
Assignees
@arbron
Labels
bug Functionality which is not working as intended localization
Milestone
D&D5E 4.2.0

Comments

@BrotherSharper
Copy link

The exhaustion rules on 2024 edition reduce the movement speed by 5 feet for each level.
However, D&D editions released outside of the US use metric conversion of 5ft = 1.5m, it would be nice if the game could account for this since the flag already exists in the settings.

Or at least remove automation from exhaustion so the users can set it on their own.
I assume this suggestion is valid for all automation that the system does and assumes for feet
@arbron arbron added bug Functionality which is not working as intended localization labels Sep 15, 2024
@arbron arbron added this to the D&D5E 4.0.1 milestone Sep 15, 2024
@arbron
Copy link
Collaborator

arbron commented Sep 15, 2024

We'll probably have to finish add the "Use Metric Length Units" setting, because right now we only have a setting for weight units (that was discussed earlier and held up this PR: #2073).

@arbron arbron removed this from the D&D5E 4.0.1 milestone Sep 15, 2024
@arbron arbron added this to the D&D5E 4.1.0 milestone Sep 25, 2024
@arbron arbron modified the milestones: D&D5E 4.1.0, D&D5E 4.2.0 Nov 6, 2024
@arbron arbron mentioned this issue Dec 12, 2024
Closed
@arbron arbron self-assigned this Dec 16, 2024
arbron added a commit that referenced this issue Dec 16, 2024
@arbron
[#4215] Ensure exhaustion speed reduction matches movement units
82e4a53 
When applying exhaustion speed reduction to an actor, this ensures
that the reduction matches the units defined on the actor. This
uses a new `convertLength` method for converting the value defined
in config from the default imperial units (e.g. `ft`) into
whatever units are used for the actor.

Closes #4215
@arbron arbron linked a pull request Dec 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
bug Functionality which is not working as intended localization
Projects
None yet
Milestone
D&D5E 4.2.0
Development

Successfully merging a pull request may close this issue.

[#4215] Ensure exhaustion speed reduction matches movement units foundryvtt/dnd5e
2 participants
@arbron @BrotherSharper