fix: dont print errors to stdout when no window id found #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when running a command this error is spewed onto the console: ``` jq: error: syntax error, unexpected ')' (Unix shell quoting issues?) at <top-level>, line 1: .. | objects | select(.id == ) | .visible jq: 1 compile error ``` This reproduces everytime for me: `fisher update; and fish_update_completions` This is because $__done_initial_window_id is empty `''` and thus causing the jq filter to fail. Regardless of whether window ID can be empty or not, the jq command stderr should be suppressed as all we care about is the exit status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when running a command this error is spewed onto the console:
This reproduces every time for me:
fisher update; and fish_update_completions(this is actually the only time it happens for me)
This is because
$__done_initial_window_idis empty''and thus causing the jq filter to fail.Regardless of whether window ID can be empty or not, the jq command stderr should be suppressed as all we care about is the exit status.