Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: save post #112

Merged
merged 16 commits into from
Sep 7, 2023
Merged

feat: save post #112

merged 16 commits into from
Sep 7, 2023

Conversation

Sembauke
Copy link
Member

@Sembauke Sembauke commented Aug 24, 2023

ref #47

closes #37
closes #40

@Sembauke Sembauke marked this pull request as ready for review September 5, 2023 18:07
@Sembauke Sembauke requested a review from a team as a code owner September 5, 2023 18:07
@sidemt sidemt self-assigned this Sep 6, 2023
@sidemt
Copy link
Member

sidemt commented Sep 6, 2023

I noticed the following issues:

  • Saved tags are not displayed when you edit the post
  • Saved title disappears when you click the edit title button

Also, is it possible to allow Editor users to add new tags in the same page? Something similar to what Ghost does.

If these are too much work for this PR, we can work on them in separate PRs.

@Sembauke
Copy link
Member Author

Sembauke commented Sep 7, 2023

  • Saved tags are not displayed when you edit the post
  • Saved title disappears when you click the edit title button

I will work on those here.

Also, is it possible to allow Editor users to add new tags in the same page? Something similar to what Ghost does.

If these are too much work for this PR, we can work on them in separate PRs.

These I'll do in a separate pr.

@Sembauke Sembauke marked this pull request as draft September 7, 2023 07:01
@Sembauke Sembauke marked this pull request as draft September 7, 2023 07:01
@Sembauke Sembauke marked this pull request as draft September 7, 2023 07:01
@Sembauke Sembauke marked this pull request as draft September 7, 2023 07:01
@Sembauke Sembauke marked this pull request as draft September 7, 2023 07:01
@Sembauke
Copy link
Member Author

Sembauke commented Sep 7, 2023

@sidemt

. Saved tags are not displayed when you edit the post

I cannot seem to do this as tags don't get returned on the post object yet.

@Sembauke Sembauke marked this pull request as ready for review September 7, 2023 10:58
@sidemt
Copy link
Member

sidemt commented Sep 7, 2023

@Sembauke Could you try adding a query string populate=tags to the API call? Details here: https://docs.strapi.io/dev-docs/api/rest/populate-select#relations--media-fields

Let me know if it doesn't work.

@sidemt
Copy link
Member

sidemt commented Sep 7, 2023

Discussed with Sem and agreed that we will fix these issues later.

@sidemt sidemt merged commit 5fc6a37 into main Sep 7, 2023
2 checks passed
@sidemt sidemt deleted the feat/submit-article branch September 7, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Article form and Edit Article form [Editor Component] Add form validation for post URL (slug)
2 participants