Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real VCardStorage in socialprovider.spec.js #106

Open
dborkan opened this issue Mar 3, 2015 · 0 comments
Open

Use real VCardStorage in socialprovider.spec.js #106

dborkan opened this issue Mar 3, 2015 · 0 comments

Comments

@dborkan
Copy link
Contributor

dborkan commented Mar 3, 2015

Currently the socialprovider.spec.js tests mock out VCardStorage in a way that doesn't accurately reflect it's real behavior, e.g. getUser is not implemented, updateProperty doesn't result in an onClientState event, etc.

We should try to use the real VCardStrorage class in socialprovider.spec.js, and just mock out freedom['core.storage'] so that save and load are both no-ops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant