-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup a new Chrome identity for the demo apps #34
Comments
what would the authorized origin / authorized redirect URI be? |
I'm not completely sure, but once we create a new project in the google developers console and use that key in manifest.json, chrome.identity.getRedirectURL() will return that URL, which we can then add to the Google Developers Console page (similar to https://console.developers.google.com/project/746567772449/apiui/credential) |
I made a new project, so that we could just have a clean ID to use here, What are the settings in that project? --Will On Tue, Apr 29, 2014 at 10:41 AM, dborkan [email protected] wrote:
|
I just added you as an owner to it so you should be able to look now. I believe we will need to:
|
Yep. Looks like this is the process outlined here: On Tue, Apr 29, 2014 at 11:02 AM, dborkan [email protected] wrote:
|
Yes, but one thing to point out is that even for the demo_google extension we are using the "Non-Google account authentication" method (chrome.identity.launchWebAuthFlow). This is because we don't want to restrict the user to their Chrome account. Also I've found that even with chrome.identity.launchWebAuthFlow, setting the "key" field in the manifest.json is still necessary, however the "oauth2" object can be omitted from manifest.json (the client_id and scopes get specified in the URL passed to chrome.identity.launchWebAuthFlow, rather than being picked up from manifest.json) |
@dborkan I know you were playing with some of this since your most recent pull request. Can I close this or is there still work to be done? |
I don't think I made any changes related to this in the recent pull request, but I'm also not sure if this is still needed. I think maybe by "identity" here I was referring to the app's key, not the identity that's used to sign into XMPP. Right now there are still some places where freedom-social-xmpp (both the demo and OAuth code) are hardcoded to use uProxy's client_id, etc. |
Set up a free identity just for the demo apps (demo and demo_google), to ensure that there aren't weird interactions between our demo apps and other install chrome apps/extensions.
The text was updated successfully, but these errors were encountered: