Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexDB storage provider assumes module context #112

Open
willscott opened this issue Oct 11, 2014 · 5 comments
Open

indexDB storage provider assumes module context #112

willscott opened this issue Oct 11, 2014 · 5 comments
Assignees
Milestone

Comments

@willscott
Copy link
Member

indexDB does not seem to be uniformly available in module contexts.
Namely, it does not exist in a safe way to use for either firefox extensions or in node sandboxes.

As such, if we need indexDB as distinct from core.storage, we should consider what that means, but implement it as a core provider if needed.

The current setup as a module, rather than a core provider indicates that the module context is currently too porous.

@ryscheng
Copy link
Member

Agreed this needs to be refactored. Pending on #110

@willscott
Copy link
Member Author

Proposing removing the indexDB provider. objections?

@ryscheng
Copy link
Member

core.indexdb?

On Wed, Jan 21, 2015 at 11:08 AM, Will [email protected] wrote:

Proposing removing the indexDB provider. objections?


Reply to this email directly or view it on GitHub
#112 (comment).

@willscott
Copy link
Member Author

@ryscheng ryscheng added this to the freedom v0.7 milestone Jan 21, 2015
@ryscheng
Copy link
Member

Okay. Talked with Will. The gameplan is to fix #208 first.
Then update the core.storage interface to support both strings and buffers.
The code for this indexDB provider will become the new provider for core.storage in freedom.
Added to 0.7 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants