Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build securedrop core release candidate packages in CI here #63

Open
redshiftzero opened this issue Jun 26, 2019 · 1 comment
Open

Build securedrop core release candidate packages in CI here #63

redshiftzero opened this issue Jun 26, 2019 · 1 comment

Comments

@redshiftzero
Copy link
Contributor

We want the following process to automate some RM tasks in SecureDrop core:

  1. Release manager pushes an rc tag in SecureDrop core
  2. CI builds all rc packages
  3. CI commit packages to lfs repo for automatic deployment to apt-test.freedom.press

The issue is that we can't put the git commit bot credentials in Circle CI in the core SecureDrop repository. We can here though since forks don't get access to Circle CI creds (indeed forked builds are off entirely).

A proposed workaround is to add a step, which is that after a release manager pushes an rc tag in securedrop core, they then push a tag here to trigger a build called securedrop-core-$TAG where $TAG is the tag to be built. We would use CircleCI's tag filtering logic to check that tag out and build, e.g. something like in the CI config:

      - build-securedrop-core-release-candidate:
          filters:
            tags:
              only:
                - /securedrop-core-*rc*/

If you see a better solution here to trigger builds on tag that does not involve giving the SecureDrop core repo credentials, please comment.

@cfm
Copy link
Member

cfm commented Aug 24, 2021

#63 (comment):

If you see a better solution here to trigger builds on tag that does not involve giving the SecureDrop core repo credentials, please comment.

One possibility would be to have securedrop's -*rc* workflow trigger a run of build-securedrop-core here via the CircleCI API. That would eliminate both the presence of securedrop code in this repository's tags and the need for the Release Manager to kick off this process manually, requiring just a $CIRCLE_API_USER_TOKEN in securedrop.

I'd be happy to pick this up as a CI priority in an upcoming sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants