Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the ariaLabel and ariaLabelledBy properties in Certificate headers #300

Open
carma12 opened this issue Mar 6, 2024 · 0 comments
Open

Comments

@carma12
Copy link
Collaborator

carma12 commented Mar 6, 2024

The headers shown in the Certificates IPA object (IpaCertificates component) are handled by the getHeaderToggleButtonProps. It has the following structure:

// Get header toggle button props
const getHeaderToggleButtonProps = (cert: CertificateData, idx: number) => {
  return {
    id: "toggle-button-" + idx,
    "aria-label": "Details",
    "aria-labelledby":
      "toggle-button card-" + parseDn(cert.certInfo.issuer).cn,
  };
};

The aria-label and the aria-labelledby properties need to be adapted to have a more descriptive name (TBD by the UX team), not making reference to the issuer (as it should be hidden until expanding the card). E.g., Details for certificate <[cert name | serial number]>.

The same should be applied to the id property:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant