Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on AJAX navigation #70

Closed
tjx666 opened this issue Nov 24, 2023 · 5 comments
Closed

Broken on AJAX navigation #70

tjx666 opened this issue Nov 24, 2023 · 5 comments
Assignees
Labels

Comments

@tjx666
Copy link

tjx666 commented Nov 24, 2023

Description

When I jump to issue page microsoft/vscode#197438 from https://github.com/microsoft/vscode/issues/ by click the pinned link, the links will not be colorized. But works after I refreash the page.

Versions

browser: chrome 119.0.6045.159

2023-11-24.16.39.53.mov
@fregante
Copy link
Owner

Indeed. I'll look into this

@fregante fregante self-assigned this Nov 24, 2023
@fregante fregante added the bug label Nov 25, 2023
@fregante
Copy link
Owner

fregante commented Dec 9, 2023

Fixed by c4f4966

Thank you for the report! I haven't used this extension for a while so it's been broken for probably a year 🥲

I'll publish a new version soon

@fregante fregante closed this as completed Dec 9, 2023
@fregante fregante changed the title doesn't work when jump from issues page Broken on AJAX navigation Dec 9, 2023
@tjx666
Copy link
Author

tjx666 commented Dec 10, 2023

Thanks your work open source

@darkred
Copy link

darkred commented Dec 15, 2023

Thanks for fixing this, @fregante.

I noticed that the action of last week for publishing v23.12.9 to CWS failed with the following error:

Error in Submit (Chrome):

relevant workflow step

Run npx chrome-webstore-upload-cli@2 upload --auto-publish
npm WARN exec The following package was not found and will be installed: [email protected]
- Fetching token
{
  "error": "invalid_grant",
  "error_description": "Bad Request"
Probably the provided refresh token is not valid. Try following the guide again
}
https://github.com/fregante/chrome-webstore-upload/blob/main/How%20to%20generate%20Google%20API%20keys.md
{
  clientId: '***',
  refreshToken: '***'
}
Error: Process completed with exit code 1.

@fregante
Copy link
Owner

Thank you! I manually uploaded the version to Chrome now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants