Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash sums always recalculated #123

Open
ppoilbarbe opened this issue Apr 21, 2022 · 4 comments
Open

hash sums always recalculated #123

ppoilbarbe opened this issue Apr 21, 2022 · 4 comments

Comments

@ppoilbarbe
Copy link

ppoilbarbe commented Apr 21, 2022

Hash sums (MD5, SHA1, SHA256...) are now always computed even if the file ".deb-control" exists with the sums already calculated.
I don't know when it begun to do this but in the past it was not redone if already present.
We have a channel with very big packages (>1GB) and very rarely modified but all sums are constantly calculated each time we add a new little package, which is very time consuming (>15min).
The version of freight used is the latest one from master branch: commit db53121, date 2021-10-08

@yegorich
Copy link

yegorich commented Apr 21, 2022

@runejuhl could you look at this?

@ppoilbarbe
Copy link
Author

For information: sums always calculated are done from files in .refs directory.
If I run clear-cache, then it rebuilds the .deb-control files, calculating the sums, then if calculates them again from files in .refs.

@runejuhl
Copy link

runejuhl commented May 4, 2022

@yegorich sorry, don't have time to look into this at the moment.

FYI my previous patch to avoid repeated hashing was to avoid a similar scenario, namely that freight would hash all existing packages whenever we added new packages, making freight take an increasingly long time to run.

@ppoilbarbe
Copy link
Author

Is there a possibility to correct it ?
I dug into the code, but it's a bit out of my skills in bash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants