Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Segment type in docs for a custom matcher #135

Open
markjaniczak opened this issue Sep 6, 2019 · 3 comments
Open

Missing Segment type in docs for a custom matcher #135

markjaniczak opened this issue Sep 6, 2019 · 3 comments

Comments

@markjaniczak
Copy link

markjaniczak commented Sep 6, 2019

I'm struggling to understand how to make a custom matcher following this doc:

https://frontarm.com/navi/en/reference/matchers/#custom-matchers

The doc above talks about needing to return an array of segment objects but I can't see segments in the Types doc:

https://frontarm.com/navi/en/reference/data-types/#segment

@jamesknelson
Copy link
Collaborator

Oh dear, that documentation seems to be quite out of date :-/

Segments are now called Chunks. I probably should just remove this from the documentation though, as custom matchers are likely to change significantly in a future version.

@markjaniczak
Copy link
Author

Ah ok - I'll keep an eye out for future updates. I managed to workaround the issue for now.

Are there any plans to allow for custom chunk types? An application of that would be for making a breadcrumb component that could build the path using all chunks in the current route of a custom type.

@jamesknelson
Copy link
Collaborator

Are there any plans to allow for custom chunk types?

I've got plans for something like this, although it's probably going to take a while to get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants