Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long term aim: Remove duplicated binary reader #298

Open
dsyme opened this issue Apr 9, 2019 · 0 comments
Open

Long term aim: Remove duplicated binary reader #298

dsyme opened this issue Apr 9, 2019 · 0 comments

Comments

@dsyme
Copy link
Contributor

dsyme commented Apr 9, 2019

The TPSDK contains 2000 lines of an IL binary reader to allow it to properly generate code (both reflection-emit and quotations) for the target set of reference assemblies.

This is problematic for two reasons

  1. There is resource duplication of IL binary readers with the host tool (devenv.exe, fsc.exe, fsi.exe etc), which are known to be hard to cache/share well. This is the cause of some recent resource usage issues with TPs in host tooling.

  2. There is code duplication ("yet another binary reader") - we would much prefer to use a standard binary reader and remove a few thousand lines from ProvidedTypes.fs

This is being discussed here Krzysztof-Cieslak/notes#1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant