Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve use case of restore that would not restore anything due to framework restriction and project being with wrong/lower framework version #4236

Open
smoothdeveloper opened this issue Dec 1, 2023 · 3 comments

Comments

@smoothdeveloper
Copy link
Contributor

Just taking a note that we should look at improving the case where paket.dependencies / paket.lock have a framework restriction, and projects get strictly 0 packages restored.

The use case is this commit: roboz0r/fable-elmish-lit-tailwind@c549d76

which requires the fixes up to this commit
smoothdeveloper/fable-elmish-lit-tailwind@5b7c5d7

@roboz0r
Copy link

roboz0r commented Dec 2, 2023

As a suggestion, when running dotnet paket install the output is:

Paket version 8.0.0+6bcb14ec191f11e984ff0e58016f5987a5cfa8f6
Skipping resolver for group Main since it is already up-to-date
Installing into projects:
Created dependency graph (14 packages in total)
Calling dotnet restore on fable-elmish-lit-tailwind.sln
  Determining projects to restore...
  Restored .\fable-elmish-lit-tailwind\src\Website.fsproj (in 843 ms).
Total time taken: 0 milliseconds

A line at the end like WARNING: 0 packages restored for .\fable-elmish-lit-tailwind\src\Website.fsproj would tip off the issue.

@smoothdeveloper
Copy link
Contributor Author

@roboz0r thanks for excellent suggestion.

I also like to keep "Total time taken: 0 milliseconds", maybe I'll color it orange when things take less than a milliseconds if the logged steps are supposed to take >= 1 milliseconds?

@roboz0r
Copy link

roboz0r commented Dec 2, 2023

I think that the timer may not be in quite the right place as even checking whether the last restore is up to date should take > 1ms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants