Support for all Trino auth mechanisms #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cccs-nik thanks for your contribution! Could you also test the new auth method in your environment? |
|
Sorry for the late reply @goodwanghan. Yup it looks good to me in our environment! I get to the point of trying to create the temp schema which gives me a permission error (I still need to tweak our Trino deployment). I can see the errored out query with my user in the Trino UI. |
|
Any insight in the failing test @goodwanghan? It fails for me on the master branch as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any chance fugue_trino could support the other authentication mechanisms trino-python-client provides (https://github.com/trinodb/trino-python-client/blob/47bbdd8d1cfd1b5dc0dea0fe9e915aeff769639d/README.md#authentication-mechanisms)? For example, in our environment we provide a custom class that is a subclass of trino.auth.JWTAuthentication for auth. This PR is a quick proof of concept that allows fugue_trino to use authentication methods beyond BasicAuthentication.
Cheers