From 74b33c73fb91b8706d7c2a4d0592c492242fca3a Mon Sep 17 00:00:00 2001 From: Alenoda <123820353+Alenoda@users.noreply.github.com> Date: Tue, 5 Nov 2024 19:17:56 +0100 Subject: [PATCH] Fix errcheck issues in server/channels/app/plugin_deadlock_test.go (#29113) Co-authored-by: Ben Schumacher --- server/.golangci.yml | 1 - server/channels/app/plugin_deadlock_test.go | 9 ++++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 0502c522611..510c5377268 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -133,7 +133,6 @@ issues: channels/app/plugin_api_tests/manual.test_http_hijack_plugin/main.go|\ channels/app/plugin_api_tests/manual.test_serve_metrics_plugin/main.go|\ channels/app/plugin_api_tests/test_update_user_auth_plugin/main.go|\ - channels/app/plugin_deadlock_test.go|\ channels/app/plugin_health_check_test.go|\ channels/app/plugin_install.go|\ channels/app/plugin_requests.go|\ diff --git a/server/channels/app/plugin_deadlock_test.go b/server/channels/app/plugin_deadlock_test.go index 78c9feffc29..caaf85a147c 100644 --- a/server/channels/app/plugin_deadlock_test.go +++ b/server/channels/app/plugin_deadlock_test.go @@ -82,7 +82,8 @@ func TestPluginDeadlock(t *testing.T) { } for _, pluginTemplate := range pluginTemplates { b := &strings.Builder{} - pluginTemplate.Execute(b, templateData) + err := pluginTemplate.Execute(b, templateData) + require.NoError(t, err) plugins = append(plugins, b.String()) } @@ -189,7 +190,8 @@ func TestPluginDeadlock(t *testing.T) { } for _, pluginTemplate := range pluginTemplates { b := &strings.Builder{} - pluginTemplate.Execute(b, templateData) + err := pluginTemplate.Execute(b, templateData) + require.NoError(t, err) plugins = append(plugins, b.String()) } @@ -272,7 +274,8 @@ func TestPluginDeadlock(t *testing.T) { } for _, pluginTemplate := range pluginTemplates { b := &strings.Builder{} - pluginTemplate.Execute(b, templateData) + err := pluginTemplate.Execute(b, templateData) + require.NoError(t, err) plugins = append(plugins, b.String()) }