Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the name walletAddress instead of accountAddress #32

Open
SametSahin10 opened this issue Mar 21, 2023 · 0 comments
Open

Use the name walletAddress instead of accountAddress #32

SametSahin10 opened this issue Mar 21, 2023 · 0 comments

Comments

@SametSahin10
Copy link
Collaborator

In StakeRequestBody and UnstakeRequestBody classes, the name accountAddress is used when it actually refers to the wallet address. The name account address implies the address of the externally owned account. So, it's better to use the name walletAddress instead of accountAddress and reserve the name account to only when an externally owned account is that is meant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SametSahin10 and others