Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Colors, Math Stuff and More Docs [Fixed] #28

Merged
merged 4 commits into from
Aug 17, 2023
Merged

New Colors, Math Stuff and More Docs [Fixed] #28

merged 4 commits into from
Aug 17, 2023

Conversation

nmsderp
Copy link
Contributor

@nmsderp nmsderp commented Aug 16, 2023

  • Added new color ,"Crimson."
  • Added math stuff (value of pi built in)
  • Docs for the math stuff (and updated color docs).

Copy link
Member

@dimkauzh dimkauzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, so I will merge this code, but I want to tell you something: you cannot use - in python, because python thinks that's a minus, you can only use _. For now it's no prob I will fix it but please next time check by yourself if your code is right. But thanks for the contribution!

@dimkauzh dimkauzh merged commit f86fa6a into fusionengine-org:dev Aug 17, 2023
1 check passed
# tbh this might get removed
class Fusion-math:
# most likely useless but i put it here anyway
self.VALUE-OF-PI = 3.141592653589793238462643383279502884197.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this get merged

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it when I was merging it lol

Copy link
Contributor

@Techsplosion Techsplosion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can't hyphen a variable in Python 3, all hail the _

# tbh this might get removed
class Fusion-math:
# most likely useless but i put it here anyway
self.VALUE-OF-PI = 3.141592653589793238462643383279502884197.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants