-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zip code and max weight validation options. Made 0 value disable some validations. #3
base: master
Are you sure you want to change the base?
Add zip code and max weight validation options. Made 0 value disable some validations. #3
Conversation
…sing the 0 value. Added support to add several zip codes to be verified.
Just modified the first pull request to use flags to enable/disable verifications and features instead of 0 value and to support several zip codes. |
Hi Filipe, I really think it's great your sending this stuff. Would you add some documentation, also to the readme, how this works. I'll pull this to my machine and look before merging |
Hi Torsten. I'm sorry about making this pull request so early and adding stuff afterwords, but when I've first pulled it I thought I had finished all the stuff I needed to had. These were changes and features I needed to add to your calculator, and thought to pull them so everyone else using you're calculator could also use them. That's why I didn't said anything before. I'm little tight on schedule but I'll try to add documentation about how it works, but that can take some time. |
Hi Torsten, Added total minimum price restriction and price by weight unit support. Started to add some info to readme. You can now pull it to your machine and try it since I've added all the features I needed and I won't update this pull request anymore unless for any bug or for adding more documentation as soon as I have some extra time to do it. Thanks and have a nice weekend. |
Hi Torsten, Just added a description of the settings I added to the calculator, hoping that it helps understanding what they do. Best regards |
@fmfdias @dancinglightning My fork is updated for Spree 2.x with full test coverage and I add @fmfdias changes to a experimental sub branch since it need a bit of work to play well with the other calculations. |
@futhr Great that you carried on. I have more or less decided to stop running after spree (since 0.0.9!) , and so won't be doing updates any more. Would you like to take this over ? I'll make a note in my rep |
@dancinglightning Ok, im willing to take command of it, but i have no interest in versions below Spree 2.0.0 so the question is how to do with them? |
There is nothing to do about them. If you want you can refer back to my
|
@fmfdias Do you still use this gem? |
No description provided.