Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zip code and max weight validation options. Made 0 value disable some validations. #3

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fmfdias
Copy link
Contributor

@fmfdias fmfdias commented Nov 23, 2012

No description provided.

@fmfdias
Copy link
Contributor Author

fmfdias commented Nov 23, 2012

Just modified the first pull request to use flags to enable/disable verifications and features instead of 0 value and to support several zip codes.

@rubydesign
Copy link
Contributor

Hi Filipe, I really think it's great your sending this stuff.
Maybe next time you add this much functionality we can talk about it before. And make it in smaller packages.

Would you add some documentation, also to the readme, how this works.

I'll pull this to my machine and look before merging

@fmfdias
Copy link
Contributor Author

fmfdias commented Nov 23, 2012

Hi Torsten.
Don't pull it now to your machine since I've got another change to make.

I'm sorry about making this pull request so early and adding stuff afterwords, but when I've first pulled it I thought I had finished all the stuff I needed to had.

These were changes and features I needed to add to your calculator, and thought to pull them so everyone else using you're calculator could also use them. That's why I didn't said anything before.

I'm little tight on schedule but I'll try to add documentation about how it works, but that can take some time.

@fmfdias
Copy link
Contributor Author

fmfdias commented Nov 23, 2012

Hi Torsten,

Added total minimum price restriction and price by weight unit support.

Started to add some info to readme.

You can now pull it to your machine and try it since I've added all the features I needed and I won't update this pull request anymore unless for any bug or for adding more documentation as soon as I have some extra time to do it.

Thanks and have a nice weekend.

@fmfdias
Copy link
Contributor Author

fmfdias commented Dec 3, 2012

Hi Torsten,

Just added a description of the settings I added to the calculator, hoping that it helps understanding what they do.
As I was doing that, I also added a description of the ones already available.

Best regards

@futhr
Copy link
Owner

futhr commented Aug 2, 2013

@fmfdias @dancinglightning My fork is updated for Spree 2.x with full test coverage and I add @fmfdias changes to a experimental sub branch since it need a bit of work to play well with the other calculations.

@rubydesign
Copy link
Contributor

@futhr Great that you carried on. I have more or less decided to stop running after spree (since 0.0.9!) , and so won't be doing updates any more.

Would you like to take this over ? I'll make a note in my rep

@futhr
Copy link
Owner

futhr commented Aug 3, 2013

@dancinglightning Ok, im willing to take command of it, but i have no interest in versions below Spree 2.0.0 so the question is how to do with them?

@rubydesign
Copy link
Contributor

There is nothing to do about them. If you want you can refer back to my
rep in your readme. It's not like it's busy and many bug fixes to do or
things.

Tobias Bohwalli mailto:[email protected]
3. elokuuta 2013 20.41

@dancinglightning https://github.com/dancinglightning Ok, im willing
to take command of it, but i have no interest in versions below Spree
2.0.0 so the question is how to do with them?


Reply to this email directly or view it on GitHub
#3 (comment).

@futhr
Copy link
Owner

futhr commented Apr 5, 2014

@fmfdias Do you still use this gem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants